Ping PR libgcj/15430

[David Daney]

Andrew Haley wrote:
> David Daney writes:
>  > It has been about a week since I posted my patch for PR libgcj/15430:
>  > 
>  > http://gcc.gnu.org/ml/java-patches/2005-q4/msg00179.html
>  > 
>  > I know that there is a small problem of code formatting (curly brace on 
>  > wrong line) and a misleading comment.  But other than that I think it is 
>  > a good patch.
>  > 
>  > OK to commit if I fix the formatting/comment problems?
> 
> Sure, it seems OK.
> 
> Does it fix the bug in general, though?  What about reads from things
> that aren't sockets?

The only bug that is fixed by the patch is libgcj/15430 which relates 
only to java.net.ServerSocket objects.

It is possible that DatagramSockets and things in java.nio.channels.* 
are effected by the same problem, but the patch does not address any 
potential problems in those classes.

I suppose that System.in could experience similar problems, but I have 
not tried to address that with the patch either.

Things that are not sockets but that can block have to be handled on a 
case by case basis.  Probably there are problems in the HTTP handlers 
that will be imported as part of classpath 0.19 in this area.

The patch fixes a specific bug.  The fact that it does not fix all bugs 
should not prevent it from being applied.

David Daney.