Patch: RFA PR libgcj/15430 (read keeps blocking after socket closed).

David Daney ddaney@avtrex.com
Thu Nov 10 00:28:00 GMT 2005


New version of the patch attached.

Tested against the testcase in the PR and with make -k check in libjava 
+ mauve with no regressions on I686-pc-linux-gnu (FC3).  This patch also 
seems to fix the mauve gnu.testlet.java.net.ServerSocket.ReturnOnClose 
FAIL (now a PASS).

OK to commit?

David Daney

2005-11-09  David Daney <ddaney@avtrex.com>

	PR libgcj/15430
	* gnu/java/net/natPlainSocketImplPosix.cc (throw_on_sock_closed): New
	function.
	(accept): Call it.
	(close): Call shutdown before closing.
	(read()): Call read_helper with proper parameters.
	(read(buffer, int, int)): Likewise.
	(read_helper):  Pass pointer to the PlainSocketImpl, remove native_fd
	and timeout parameters.  Make prototype to match. Use
	pointer to PlainSocketImpl to access members. Call throw_on_sock_closed
	in two places.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: psip.d
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20051110/8f7c7c8e/attachment.ksh>


More information about the Java-patches mailing list