[patch] Fix PR23230 - wrong code generated in inner class

Ranjit Mathew rmathew@gmail.com
Thu Aug 11 05:12:00 GMT 2005


On 8/10/05, Bryce McKinlay <mckinlay@redhat.com> wrote:
> Robin Green wrote:
> 
> >>Jacks is most likely not the place for such a testcase - AFAICT, they
> >>only check for compilation success, error or warning.
> >>
> >>
> >
> >That's not the case. There are runtime tests as well. It is a JLS test not a
> >test of any specific API, so it should go in Jacks, I think - but I will
> >double-check on that when I submit it.
> >
> >
> 
> Regression tests for gcj PRs should go in libjava/testsuite, so please
> include the regression test when you check in your patch. Tests that are
> actually in the gcc tree are more likely to get run by "random gcc
> hackers", so its good to have as many tests in there as possible.
> 
> Of course, if no test for this currently exists in jacks, then it would
> be great to put it in there as well.

Tom has already checked in the testcase, on Robin's behalf,
into Jacks. IMHO, it doesn't make sense to repeat the testcase
in the libjava testsuite.

It might be better to just import Jacks lock-stock-and-barrel
into the libjava testsuite (as is done for GNU Classpath now).

Ranjit.

PS: Robin, you still haven't checked in your patch.

-- 
Ranjit Mathew      Email: rmathew AT gmail DOT com

Bangalore, INDIA.    Web: http://ranjitmathew.hostingzero.com/



More information about the Java-patches mailing list