[patch] libffi: SH: fix on sh3

Kaz Kojima kkojima@rr.iij4u.or.jp
Fri Jul 22 06:28:00 GMT 2005


SUGIOKA Toshinobu <sugioka@itonet.co.jp> wrote:
> On sh3, struct argument may passed partially on register and the rest
> on stack. Mainline does not handle this case correctly.
> I think it's better to change stack layout in ffi_closure_SYSV so that
> arguments are stored in contiguous address.
> 
> The result of make check on sh3-linux is
> 
>                 === libffi Summary ===
> 
> # of expected passes            228
> # of unsupported tests          2

This is fine, though I'm not qualified to approve it.

A minor nit, it looks the last line of the ChangeLog entry
has a cut&paste error.  I suppose it would be

	(ffi_prep_cif_machdep): Don't set too many cif->flags.

BTW, please don't forget -p option to diff next time :-)

Regards,
	kaz



More information about the Java-patches mailing list