[RFA/JDWP] StringReferenceCommandSet.java

Aaron Luchko aluchko@redhat.com
Wed Jun 29 20:08:00 GMT 2005


Okay, this is the first implementation of a CommandSet.

http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_StringReference

All the CommandSets will end up following this pattern. Each command in
the command set will be implemented with a method named
execute<Command>. In this case the value command is implemented by
executeValue. A switch on the command will then be used to find the
appropriate method. The reason I'm still using a switch in this class
even though there's only a single command to choose from is consistency
with the rest of the CommandSets.

One additional thing I was wondering about is the comments for classes
implementing an interface. There's nothing specific about any of the
runCommands that should require a specific javadoc and running javadoc
will pick up the command of the interface defining the method if there
isn't a comment where it's implemented. However that will mean there
won't be any comments when one's looking at the actual code.

For the moment I'm just leaving the comment out.

Aaron


ChangeLog
2005-06-29  Aaron Luchko  <aluchko@redhat.com>

        * gnu/classpath/jdwp/processor/StringReferenceCommandSet.java:
New file.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: jdwpStringReference.patch
Type: text/x-patch
Size: 3712 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20050629/9e708d3c/attachment.bin>


More information about the Java-patches mailing list