[cp-patches] Re: Patch: FYI: fix http Headers oddity

[Bryce McKinlay]

Chris Burdess wrote:

>Bryce McKinlay wrote:
>  
>
>>Does anyone know why we use the custom "LineInputStream" class instead 
>>of, say, BufferedReader here? At one point BufferedReader.readLine() was 
>>buggy and could "read too much" and block before returning a line, but I 
>>believe we have fixed that. Code re-use would help to avoid bugs like 
>>this ;-)
>>    
>>
>
>Erm, because LineInputStream is an InputStream dealing with bytes, and
>BufferedReader is a Reader dealing with chars.
>  
>

Why is this distinction important? We are converting the result to chars 
(well, a String) anyway.

Bryce