[cp-patches] [patch] document BufferCapabilities
Mark Wielaard
mark@klomp.org
Thu May 5 08:28:00 GMT 2005
Hi,
On Wed, 2005-05-04 at 18:17 -0400, Thomas Fitzsimmons wrote:
> 2005-05-04 Thomas Fitzsimmons <fitzsim@redhat.com>
>
> * java/awt/BufferCapabilities.java: Document.
This broke the GNU Classpath build:
/**
* Creates a buffer capabilities object.
*
- * @exception IllegalArgumentException If frontCaps or backCaps are null.
+ * @param frontCaps front buffer capabilities descriptor
+ * @param backCaps back buffer capabilities descriptor
+ * @param flipContents the results of a flip operation or null if
+ * flipping is not supported
+ *
+ * @exception IllegalArgumentException if frontCaps or backCaps is
+ * null
*/
- public BufferCapabilities(ImageCapabilities front, ImageCapabilities back,
- FlipContents flip)
+ public BufferCapabilities(ImageCapabilities frontCaps,
+ ImageCapabilities backCaps,
+ FlipContents flipContents)
But now the arguments and the code don't match so we get errors like:
../java/awt/BufferCapabilities.java: In class `java.awt.BufferCapabilities':
../java/awt/BufferCapabilities.java: In constructor `(java.awt.ImageCapabilities,java.awt.ImageCapabilities,java.awt.BufferCapabilities$FlipContents)':
../java/awt/BufferCapabilities.java:147: error: variable 'front' may not have been initialized.
if (front == null || back == null)
^
../java/awt/BufferCapabilities.java:147: error: variable 'back' may not have been initialized.
if (front == null || back == null)
^
../java/awt/BufferCapabilities.java:151: error: variable 'flip' may not have been initialized.
this.flip = flip;
^
3 errors
Obvious fix checked into GNU Classpath CVS:
2005-05-04 Mark Wielaard <mark@klomp.org>
* java/awt/BufferCapabilities.java (BufferCapabilities): Make
documentation of arguments match code.
Cheers,
Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: BufferCapabilities.patch
Type: text/x-patch
Size: 1406 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20050505/01cd96f9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20050505/01cd96f9/attachment.sig>
More information about the Java-patches
mailing list