[Patch] gnu.java.net.protocol.file.Connection

Michael Koch konqueror@gmx.de
Thu Apr 28 17:26:00 GMT 2005


Hi list,


I just merged the attached patch to merge
gnu.java.net.protocol.file.Connection with GNU classpath again.


Michael


2005-04-28  Jeroen Frijters  <jeroen@frijters.net>

	* gnu/java/net/protocol/file/Connection.java
	(StaticData): New inner class to contain statics.
	(connect, getHeaderField): Modified to use StaticData.

2005-04-28  Michael Koch  <konqueror@gmx.de>

	* gnu/java/net/protocol/file/Connection.java
	(lineSeparator): Initialize with SystemProperties.getProperty().

-------------- next part --------------
Index: gnu/java/net/protocol/file/Connection.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/net/protocol/file/Connection.java,v
retrieving revision 1.11
diff -u -r1.11 Connection.java
--- gnu/java/net/protocol/file/Connection.java	27 Apr 2005 21:02:59 -0000	1.11
+++ gnu/java/net/protocol/file/Connection.java	28 Apr 2005 17:24:42 -0000
@@ -37,7 +37,7 @@
 
 package gnu.java.net.protocol.file;
 
-import gnu.java.security.action.GetPropertyAction;
+import gnu.classpath.SystemProperties;
 
 import java.io.BufferedInputStream;
 import java.io.BufferedOutputStream;
@@ -56,7 +56,6 @@
 import java.net.URL;
 import java.net.URLConnection;
 import java.security.Permission;
-import java.security.AccessController;
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.Locale;
@@ -76,23 +75,19 @@
    */
   private static final String DEFAULT_PERMISSION = "read";
 
-  /**
-   * HTTP-style DateFormat, used to format the last-modified header.
-   */
-  private static SimpleDateFormat dateFormat
-    = new SimpleDateFormat("EEE, dd MMM yyyy hh:mm:ss 'GMT'",
-                           new Locale ("En", "Us", "Unix"));
-
-  private static String lineSeparator;
-  
-  static
+  private static class StaticData
   {
-    if (lineSeparator == null)
-      {
-	GetPropertyAction getProperty = new GetPropertyAction("line.separator");
-	lineSeparator = (String) AccessController.doPrivileged(getProperty);
-      }
+    /**
+     * HTTP-style DateFormat, used to format the last-modified header.
+     */
+    static SimpleDateFormat dateFormat
+      = new SimpleDateFormat("EEE, dd MMM yyyy hh:mm:ss 'GMT'",
+                             new Locale ("En", "Us", "Unix"));
+
+    static String lineSeparator =
+      SystemProperties.getProperty("line.separator");
   }
+
   
   /**
    * This is a File object for this connection
@@ -182,7 +177,7 @@
         for (int i = 0; i < files.length; i++)
           {
             writer.write(files[i]);
-            writer.write(lineSeparator);
+            writer.write(StaticData.lineSeparator);
           }
 
         directoryListing = sink.toByteArray();
@@ -271,9 +266,10 @@
           }
 	else if (field.equals("last-modified"))
 	  {
-	    synchronized (dateFormat)
+	    synchronized (StaticData.dateFormat)
 	      {
-        	return dateFormat.format(new Date(file.lastModified()));
+        	return StaticData.dateFormat.format(
+                        new Date(file.lastModified()));
 	      }
 	  }
       }


More information about the Java-patches mailing list