Patch: FYI: FileChannelImpl fixlet

Tom Tromey tromey@redhat.com
Tue Apr 26 21:46:00 GMT 2005


I'm checking this in to libgcj and Classpath.

This fixes a small bug in FileChannelImpl; it comes from a libgcj PR.

Tom

Index: ChangeLog
from  Luca Barbieri  <luca.barbieri@gmail.com>

	PR libgcj/21136:
	* gnu/java/nio/channels/FileChannelImpl.java (tryLock): Pass
	'false' to native lock().
	(lock): Pass 'true' to native lock().

Index: gnu/java/nio/channels/FileChannelImpl.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/nio/channels/FileChannelImpl.java,v
retrieving revision 1.8
diff -u -r1.8 FileChannelImpl.java
--- gnu/java/nio/channels/FileChannelImpl.java 10 Mar 2005 15:29:15 -0000 1.8
+++ gnu/java/nio/channels/FileChannelImpl.java 26 Apr 2005 21:44:36 -0000
@@ -419,7 +419,7 @@
     try
       {
 	begin();
-        lock(position, size, shared, true);
+        lock(position, size, shared, false);
 	completed = true;
 	return new FileLockImpl(this, position, size, shared);
       }
@@ -451,7 +451,7 @@
 
     try
       {
-	boolean lockable = lock(position, size, shared, false);
+	boolean lockable = lock(position, size, shared, true);
 	completed = true;
 	return (lockable
 		? new FileLockImpl(this, position, size, shared)



More information about the Java-patches mailing list