[patch] FYI: gij -version quotes

Ranjit Mathew rmathew@gmail.com
Tue Apr 26 10:44:00 GMT 2005


Thomas Fitzsimmons wrote:
> Hi,
> 
> I committed this patch to mainline as obvious.  The java version printed
> by gij -version should be quoted.

You might want to backport this to the 4.0.x branch
as it seems some programs (including OpenOffice.org)
actually depend on this bit. :-/

See PR21233:

  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21233

Ranjit.


> Tom
> 
> 2005-04-14  Thomas Fitzsimmons  <fitzsim@redhat.com>
> 
> 	* gij.cc (version): Properly quote java version.
> 	(main): Fix typo in comment.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gcc/gcc/libjava/ChangeLog,v
> retrieving revision 1.3470
> diff -u -r1.3470 ChangeLog
> --- ChangeLog	13 Apr 2005 16:37:19 -0000	1.3470
> +++ ChangeLog	15 Apr 2005 02:32:44 -0000
> @@ -1,3 +1,8 @@
> +2005-04-13  Thomas Fitzsimmons  <fitzsim@redhat.com>
> +
> +	* gij.cc (version): Properly quote java version.
> +	(main): Fix typo in comment.
> +
>  2005-04-07  Thomas Fitzsimmons  <fitzsim@redhat.com>
>  
>  	* prims.cc (parse_verbose_args): Fix verbose argument parsing.
> Index: gij.cc
> ===================================================================
> RCS file: /cvs/gcc/gcc/libjava/gij.cc,v
> retrieving revision 1.26
> diff -u -r1.26 gij.cc
> --- gij.cc	2 Apr 2005 02:26:50 -0000	1.26
> +++ gij.cc	15 Apr 2005 02:32:44 -0000
> @@ -40,7 +40,7 @@
>  static void
>  version ()
>  {
> -  printf ("java version " JV_VERSION "\n");
> +  printf ("java version \"" JV_VERSION "\"\n");
>    printf ("gij (GNU libgcj) version %s\n\n", __VERSION__);
>    printf ("Copyright (C) 2005 Free Software Foundation, Inc.\n");
>    printf ("This is free software; see the source for copying conditions.  There is NO\n");
> @@ -315,7 +315,7 @@
>      }
>  
>    // -jar mode overrides all other modes of specifying class path:
> -  // -CLASSPATH, -Djava.class.path, -classpath and -cp.
> +  // CLASSPATH, -Djava.class.path, -classpath and -cp.
>    if (jar_mode)
>      {
>        char* darg = (char*) JvMalloc (strlen (argv[i])


-- 
Ranjit Mathew      Email: rmathew AT gmail DOT com

Bangalore, INDIA.    Web: http://ranjitmathew.hostingzero.com/



More information about the Java-patches mailing list