review of libtool patch

Alexandre Oliva aoliva@redhat.com
Sun Apr 17 02:31:00 GMT 2005


On Apr 16, 2005, Tom Tromey <tromey@redhat.com> wrote:

> Could you look at this patch?

>     http://gcc.gnu.org/ml/gcc-patches/2005-03/msg02792.html

> This affects libgcj builds on some systems -- it depends on the order
> in which a certain 'find' prints its results.  This affects 4.0 as
> well.

Backporting the patch from upstream libtool is definitely a better
idea.  It woudl be better to test for the need for quoting the src
with a `case' construct, which we have in several such places, instead
of forking out yet another process for every input file.  Libtool is
slow enough as is :-/

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}



More information about the Java-patches mailing list