Fallout (mostly runtime library-related) from GCC version number change

Zack Weinberg zack@codesourcery.com
Thu Mar 17 16:52:00 GMT 2005


Paolo Bonzini <bonzini@gnu.org> writes:

> Zack Weinberg wrote:
>> This lengthy patch attempts to address consequences of the change to
>> the way the compiler itself determines its version number, upon a
>> bunch of other top-level directories.  I erred in not checking the
>> entire source tree for constructs similar to the ones dealt with in
>> this patch; also in not thoroughly testing 'make install'.
>
> FWIW, the patch looks ok to me, but I would not use $(shell ...);

Note the rather more elaborate text-processing convolutions in the
definition of DATESTAMP_s and DEVPHASE_s.  $(shell) is necessary
there, and having been used there it makes sense to use it everywhere.

:= might make sense, but it seemed to me that it would be better to do
this lazily so that make invocations that never referred to these
variables did not need to read the files.  (What one really wants is
'evaluate this no more than once'...)

zw



More information about the Java-patches mailing list