[Patch] Fix Socket read returns EOF when count == 0...
David Daney
ddaney@avtrex.com
Tue Mar 15 17:41:00 GMT 2005
Michael Koch wrote:
> On Mon, Mar 14, 2005 at 04:16:54PM -0800, David Daney wrote:
>
>>Tom Tromey wrote:
>>
>>>>>>>>"David" == David Daney <ddaney@avtrex.com> writes:
>>>
>>>David> Tested on the HEAD on i686-pc-linux with make check in libjava with no
>>>David> regressions. No regressions in mauve in the 4.0 branch (HEAD not
>>>David> tested in mauve due to ICE in mauve)
>>>David> 2005-03-14 David Daney <ddaney@avtrex.com>
>>>David> * gnu/java/net/natPlainSocketImplPosix.cc (read_helper): Handle
>>>David> count == 0 case.
>>>David> O.K to commit to HEAD?
>>>David> How about the 4.0 branch for good measure?
>>>Yes to both. Thanks.
>>>FWIW I think the Win32 code needs this as well.
>>
>>FWIW I don't currently have a mandate to fix/test Win32 things (x86-linux is pushing it).
>
>
> I think it falls under the obvious rule in this case.
>
It may be obvious, but my understanding of the 'obvious' rule as it
applies to code is that the All-patches-must-be-thoroughly-tested rule
still applies.
I will not be testing Win32 code so it seems that I should not be
committing random changes to it either.
David Daney.
More information about the Java-patches
mailing list