[RFC/RFT] Patch (java): Switch to new verifier

Bryce McKinlay mckinlay@redhat.com
Sat Mar 5 12:26:00 GMT 2005


Andrew Haley wrote:

>Bryce McKinlay writes:
> > > 
> > >Also, I suspect that the new verifier generates typemaps that require
> > >special treatment by subsequent code-generation passes.  There are
> > >hacks in place for this, but I'm not sure they work when compiling
> > >with the C++ ABI.
> > >  
>
> > Andrew may correct me, but I don't recall anything we did for the new 
> > verifier that will be incompatible with the C++ ABI. It does seem to 
> > work ok on my (very brief) testing. It would be nice to get rid of the 
> > old verifier - there's no point keeping it around if the new one can be 
> > made to work.
>
>This looks pretty good.  You test it and I'll approve it.
>  
>

Here's the patch. This cleans up all the #if 0 blocks, removing unused 
code. It also incorporates a few minor improvments that I had sitting in 
my tree: improves verifier error messages by reporting the PC in more 
cases, and fixes a probable memory leak. It also incorporates Ranjit's 
expr.c flag_new_verifier fix.

No regressions, and 4 XPASS's when the new verifier is enabled for the 
C++ ABI.

I think this patch should go into both HEAD and the branch - note that 
its pretty benign since it doesn't actually enable the new verifier code 
for the C++ ABI yet, and the changes for the BC-ABI are basically just 
cleanups. OK?

Bryce

-------------- next part --------------
A non-text attachment was scrubbed...
Name: java-verifier-cleanup.patch
Type: text/x-patch
Size: 9638 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20050305/45dc6eb0/attachment.bin>


More information about the Java-patches mailing list