[RFC/RFT] Patch (java): Switch to new verifier

Tom Tromey tromey@redhat.com
Fri Mar 4 19:22:00 GMT 2005


>>>>> "Andrew" == Andrew Haley <aph@redhat.com> writes:

>> Andrew may correct me, but I don't recall anything we did for the new 
>> verifier that will be incompatible with the C++ ABI. It does seem to 
>> work ok on my (very brief) testing. It would be nice to get rid of the 
>> old verifier - there's no point keeping it around if the new one can be 
>> made to work.

Andrew> This looks pretty good.  You test it and I'll approve it.

I assume we're talking about CVS trunk here?
(IMO this is too risky for 4.0.)

The other thing that needs to be cleaned up in this area is verifier
failures.  Right now if the verifier rejects a method, we print an
error message and continue.  It seems to me that this will result in
ICEs later on in some situations.

There are a couple other cleanups to look at:

- What about the #if 0 code in verify-glue.c?
- Should remove the #if 0 code from verify-impl.c.

Tom



More information about the Java-patches mailing list