Verifying zip entries that don't exist in the JarFile

Bryce McKinlay mckinlay@redhat.com
Mon Feb 21 21:39:00 GMT 2005


Mark Wielaard wrote:

>Hi,
>
>Sometimes a jar signature file contains signatures for .class files not
>included in the jar file itself (which is probably a packaging problem).
>This patch handles such situations gracefully.
>
>2005-02-21  Mark Wielaard  <mark@klomp.org>
>
>        * java/util/jar/JarFile.java (verifyHashes): Check whether ZipEntry
>        exists.
>
>Without this patch we would throw a NullPointerException in the middle
>of loading the jar file. Found by playing a bit with Netx a GPLed JNLP
>implementation which kind of works (unfortunately only when turning off
>the build in SecurityManager which goes into some infinite loop, which
>need investigation). Some of the simpler jnlp examples actually start up
>with a recent gij.
>
>OK to commit?
>  
>
OK.

Not a problem with your patch, but shouldn't DEBUG variable in 
JarFile.java should be final?

Bryce



More information about the Java-patches mailing list