Patch: normalize x86 os.arch for non-Windows platforms

Tom Tromey tromey@redhat.com
Mon Feb 14 20:27:00 GMT 2005


>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

Anthony> 2005-02-13  Anthony Green  <green@redhat.com>
Anthony> * java/lang/natRuntime.cc (insertSystemProperties): Normalize x86
Anthony> architecture names to "i386" for compatibility reasons.  Win32
Anthony> still uses "x86".

Anthony> +      // is handled in win32.cc).
Anthony> +      if (u.machine[0] == 'i'
Anthony> +	  && u.machine[2] == '8'
Anthony> +	  && u.machine[3] == '6'
Anthony> +	  && u.machine[4] == 0)

Could you add '&& u.machine[1] != 0' in there?
Maybe this is overly pedantic.

Otherwise this is ok, thanks.

Tom



More information about the Java-patches mailing list