Patch: GregorianCalendar returns bad values from getMinimum().

Michael Koch konqueror@gmx.de
Mon Feb 7 13:21:00 GMT 2005


On Sun, Feb 06, 2005 at 01:12:58PM -0500, Bryce McKinlay wrote:
> On 6-Feb-05, at 9:11 AM, Sven de Marothy wrote:
> 
> >Yes, I included David's fix in my most recent patch. But in the context
> >of how much was and is broken with GregorianCalendar, it's a minor bug.
> >I don't see why you're discussing this. You should merge in the
> >Classpath versions of these classes ASAP and perhaps close some of 
> >those
> >related Bugzilla bugs.
> 
> Agreed.
> 
> >>>There are a few changes in Classpath that are not reflected in 
> >>>libgcj,
> >>>however I wouldn't call it a rewrite. Someone has gone and rather
> >>>gratuitously reformatted a bunch of code and created a lot of diffs, 
> >>>but
> >>>there's only a few significant code changes.
> >
> >Well, my only comment is that I feel the changes were significant. The
> >old code was broken in nearly every way. There were also what appear to
> >be ad-hoc 'fixes' introduced into the code, which didn't really fix
> >things.
> 
> 
> Sure, I apologise - I didn't mean to suggest that these wern't good and 
> significant fixes! Just that Michael had suggested that the classes had 
> been "rewritten" which could imply a lot more merging work than really 
> exists.

Well, I meant "rewritten" as in "significant code changes". If there are
no changes in libgcj that are not in classpath too we can just copy over
the files. I just wanted make sure this is possible later.


Michael
-- 
Senior Developer
Enough Software
Vor dem Steintor 218, 28203 Bremen, Germany
mail: robert@enough.de
http: www.enough.de, www.j2mepolish.org



More information about the Java-patches mailing list