Patch: GregorianCalendar returns bad values from getMinimum().

Bryce McKinlay mckinlay@redhat.com
Sun Feb 6 12:05:00 GMT 2005


David Daney wrote:

Note that these classes are improved an mainly rewritten much in GNU
classpath. It perhaps just be better to merge all needed stuff from
there instead of applying different patches here and there and then
getting headaches while merging again. 

There are a few changes in Classpath that are not reflected in libgcj, 
however I wouldn't call it a rewrite. Someone has gone and rather 
gratuitously reformatted a bunch of code and created a lot of diffs, but 
there's only a few significant code changes. It does appear this bug is 
still present in the classpath version:

 /**
  * The minimum values for the calendar fields.
  */
 private static final int[] minimums =
                                       {
                                         BC, 1, 0, 0, 1, 1, 1, SUNDAY, 
1, AM,
                                         1, 0, 1, 1, 1, -(12 * 60 * 60 
* 1000),
                                         0
                                       };


If this bug is fixed in Classpath, I don't care if you merge it from 
there or we apply my patch.  I don't want to have to patch libgcj 4.0 
(when it is released) to get a working version.

I will defer checking in until I hear from Bryce (Or Tom Tromey). 


I will re-sync GregorianCalendar with Classpath once gcc.gnu.org is back 
up. I can apply your patch in the process and make sure it goes into 
classpath as well.

Regards

Bryce




More information about the Java-patches mailing list