Patch: IP_MULTICAST_LOOP support

Tom Tromey tromey@redhat.com
Mon Jan 31 20:04:00 GMT 2005


>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

>> http://www.linux.org/docs/ldp/howto/Multicast-HOWTO-6.html
>> ... the 'val' argument must be an 'unsigned char'.

Anthony> "must be"?  I thought there was some flexibility here, as we
Anthony> also pass the size of 'val' as the last argument.

Yeah, I wonder about that.  It is conceivable that the kernel just
checks the value and if it is not '1', returns EINVAL.  Could you
check this?  I'm ok with an actual test or with just looking at the
kernel source.  Or I suppose finding a definitive source for the docs,
SUS or something.

I also wonder whether the getsockopt code for this option is correct.

Anthony> The attached patch also enables the SO_REUSEADDR option.  I
Anthony> think this was disabled in error..

I tracked this down to the very beginnings of our java.net, as written
by Warren.  My random googling shows that this is probably incorrect
though.

This part of the patch is fine as far as it goes... but could you
also fix the getsockopt part?

Tom



More information about the Java-patches mailing list