[Patch] PR libgcj/19444 - java.net.URI fixes

Mark Wielaard mark@klomp.org
Sat Jan 15 16:47:00 GMT 2005


On Sat, 2005-01-15 at 17:22 +0100, Michael Koch wrote:
> +           if (portStr != null)
> +             try
> +               {
> +                 port = Integer.parseInt(portStr);
> +               }
> +             catch (NumberFormatException e)
> +               {
> +                 URISyntaxException use = new URISyntaxException(str, "doesn't match URI regular expression");
> +                 use.initCause(e);
> +                 throw e;
> +               }

Please wrap that long line.
And you want to throw the URISyntaxException use, not just the
NumberFormatException e.

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20050115/c87eb5f1/attachment.sig>


More information about the Java-patches mailing list