[cp-patches] [Patch][gui] javax.swing.JTree

Michael Koch konqueror@gmx.de
Sat Jan 1 16:26:00 GMT 2005


Am Samstag, 1. Januar 2005 16:47 schrieb Mark Wielaard:
> Hi,
>
> > 2004-12-31  Michael Koch  <konqueror@gmx.de>
> >
> >  * javax/swing/JTree.java
> >  (hasChildren): New instance field.
>
> I assume this is DynamicUtilTreeNode.hasChildren. Try to mention
> the inner class if you change one.

Damn, you are right.

> > +    /**
> > +     * XXX: Currently not implemented.
> > +     */
> > +    protected boolean hasChildren;
>
> Eh. What does it? If it isn't implemented, why do we have a dummy
> field? (no more stubs!) Could you at least document that it always
> returns false.

Its no stub. Its this way intentional. In our implementation it always 
returns false but even this is not guaranteed as this field is not 
used according to SUNs javadocs. The problem is that 2rd party 
software might use it already. But they have to take care about the 
value of the field themself.


Michael
-- 
Homepage: http://www.worldforge.org/



More information about the Java-patches mailing list