[PATCH] Fix PACKAGE_* redefined warnings in libjava.

Kelley Cook kcook@gcc.gnu.org
Thu Oct 7 18:59:00 GMT 2004


--- Bryce McKinlay <mckinlay@redhat.com> wrote:

> Kelly,
> 
> Just FYI: "gc_config.h" was introduced partly to avoid the PACKAGE_* 
> redefinition warnings. gc_config.h.in was deliberately not 
> autoheader-generated, so that it only exported a few symbols that
> needed 
> to be "public" ie visibile to clients outside the GC - ie libjava. Is
> there any reason why gc_config.h.in must be an autoheader generated
> file?

Of course it isn't a "must" to autogenerate gc_config.h.in, hence
option 1) which revert the previous patch.

On the otherhand, installing this patch lets autoreconf work again and
reduces the chance that a particular AC_DEFINE is added to configure.ac
or *.m4, but not to the corresponding gc_config.h.in.

I really don't feel strongly one way or the other.  Since, I caused the
problem, I suggested two options to fix it.

KC



More information about the Java-patches mailing list