[patch] Implement java.beans.Expression

Tom Tromey tromey@redhat.com
Mon Jun 28 21:40:00 GMT 2004


>>>>> "Jerry" == Jerry Quinn <jlquinn@optonline.net> writes:

Jerry> Mauve test checked in and passes.

Excellent.

Jerry> 2004-06-24  Jerry Quinn  <jlquinn@optonline.net>
Jerry> 	* java/beans/Expression.java: New.
Jerry> 	* Makefile.am: Add Expression.java.
Jerry> 	* Makefile.in: Regenerate.

Looks good.  Thanks for doing this.  Just two little style nits.

Jerry> +  public Expression(Object value, Object target, String methodName, Object[] arguments)

This looks longer than 80 chars, so wrap after one of the ","s.
You can just commit with this change.

Jerry> +  public void setValue(Object value) { this.value = value; }

This needs the multi-line treatment.

Tom



More information about the Java-patches mailing list