recent regression

Ranjit Mathew rmathew@gmail.com
Sun Jun 27 19:30:00 GMT 2004


On Fri, 25 Jun 2004 17:37:58 -0400, Bryce McKinlay <mckinlay@redhat.com> wrote:
> 
> 
> Ranjit Mathew wrote:
> 
> >>Would it not it be better to simply avoid calling read_class in the
> >>CLASS_FROM_SOURCE_P case? If you have a type decl for a class and
> >>CLASS_FROM_SOURCE_P is true, then (afaik) it must by definition be
> >>already loaded and been/being parsed. How about the following patch instead:
> >>
> >>
> >[...]
> >
> >
> >>This would also allow us to get rid of many of the CLASS_FROM_SOURCE_P
> >>checks scattered around parse.y.
[...]
> Agreed. Here's a complete patch with redundant CLASS_FROM_SOURCE_P's
> removed. I've run this through the testsuite (no regressions), and also
> built parts of RHUG against it. It seems to fix PR 16768 as well.

Bryce,

    You might want to simplify this idiom in other files (not just parse.y)
as well.

Ranjit.



More information about the Java-patches mailing list