Patch: FYI: PR 16134

Bryce McKinlay mckinlay@redhat.com
Wed Jun 23 03:50:00 GMT 2004


Tom Tromey wrote:

>>>>>>"Bryce" == Bryce McKinlay <mckinlay@redhat.com> writes:
>>>>>>            
>>>>>>
>
>Bryce> Hmm, the catch here is that we could now not cache iconv() encoders,
>Bryce> if the name gets canonicalized, because the name in the cache for
>Bryce> Iconv encoders won't match the canonicalized name.
>
>Yeah :-(.  I suppose we could compare against both names, but that
>doesn't seem too good.  Alternatively we could pass both the canonical
>and unmodified names to the iconv constructors, and have their
>getName() methods return the canonical names.
>  
>

Actually I don't think it matters, since all the canonical encoder names 
we recognise are implemented in Java (I think). ie: encoder names that 
go through to iconv() will not be canonicalized.

Regards

Bryce



More information about the Java-patches mailing list