Patch: FYI: PR 16134

Bryce McKinlay mckinlay@redhat.com
Tue Jun 22 19:14:00 GMT 2004


Tom Tromey wrote:

>The original intent of this code was that the original (non-canonical)
>name be passed to the iconv converter.  The idea is that our
>canonicalization might result in a name not known by the underlying
>iconv implementation.
>
>This patch changes that.  And actually I don't know that this has ever
>mattered.  But it would be simple to restore this behavior by keeping
>the non-canonical name and passing it to the iconv converter
>constructor.
>  
>

Hmm, the catch here is that we could now not cache iconv() encoders, if 
the name gets canonicalized, because the name in the cache for Iconv 
encoders won't match the canonicalized name.

Bryce



More information about the Java-patches mailing list