[patch] Fix java.util.zip.ZipEntry.setTime

Tom Tromey tromey@redhat.com
Tue Jun 15 01:40:00 GMT 2004


>>>>> "Jerry" == Jerry Quinn <jlquinn@optonline.net> writes:

Jerry> Currently, setTime mangles the time by scaling, constructing dostime,
Jerry> then unscaling dostime.  The scaling is unnecessary.

Could you expand on that a bit?

My understanding is that DOS stores time in seconds, whereas Date
wants milliseconds.  Hence the scaling and unscaling.

Jerry> -    dostime = (int) (dostime / 1000L);

It seems like this line ought to be within the `synchronized'
statement.

Tom



More information about the Java-patches mailing list