Patch: java.text collators

[Michael Koch]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Dienstag, 1. Juni 2004 00:03 schrieb Bryce McKinlay:
> Michael Koch wrote:
> >I merged the attached patch locally from GNU classpath and saw
> > that all mauve testcases for java.text.CollationElementIterator
> > and java.text.RuleBaseCollator pass now. That's really amazing
> > work by Guilhem Lavaux and gives us the possibility to merge
> > future fixes to this code easily. This also removes the xfailed
> > tests.
>
> Wow - great stuff!
>
> >Okay to commit to trunk ?
>
> OK, with a few comments:
> >+    Vector v = new Vector();
> >+    Vector vi = new Vector();
> >+
> >+    // Build element collection ordered as they come in "text".
> >+    while (idx < work_text.length())
>
> Could ArrayList be used here?
>
> >+	    key = work_text.substring (idx, idx+p);
> >+	    object = collator.prefix_tree.get (key);
>
> There are a few formatting errors here. These should ideally be
> cleaned up so that there isn't a space between the method name and
> arguments/braces.

Commited now as is. The suggested fixes will be addressed in an 
upcoming patch.


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAu68iWSOgCCdjSDsRAvm2AJ91WgX0mxjFVFIuYM8bPMLGnXuKFgCbB6Zc
WHtw83PpXk9t0qWx8PQPM+s=
=iRn5
-----END PGP SIGNATURE-----