Line number support for interpreter

Mark Wielaard mark@klomp.org
Sun May 16 18:37:00 GMT 2004


Hi,

On Mon, 2004-05-10 at 02:00, Mark Wielaard wrote:
> I haven't tested the patch very much yet. But a simple test class that
> throws some exceptions works and shows the correct line numbers. And I
> am able to startup eclipse (2.1.2) with it under plain or
> direct-threaded interpreter. (This was also the motivation for the patch
> since I use to run eclipse under gij and got annoyed by the fact that
> exceptions didn't have source and line numbers.)

I forgot to mention that I made it against 3.4 sources.
The attached patch is against CVS HEAD.

I tested it some more and it doesn't give regressions (and as mentioned
above eclipse 2.1.2 runs with this). But I haven't checked against Mauve
yet. And I found at least one example which breaks with this code. I
made the attached Invoke.java test (using reflection to call an
interface method on an object that implements that interface).
I cannot figure out what I changed that causes this to fail with my
patch. Anyone a clue?

It might be a good idea to add this small test to testsuite/libjava.lang
since it seems a strange corner case that isn't normally tested/used.

Note that is only a port of the original patch to CVS head, I have not
yet implemented any of the suggestions of Tom and Bryce (who was so nice
to take a look and give some comments on IRC). The patch also includes
the fix that was made for 3.4 to get interpret.cc working again
(http://gcc.gnu.org/PR13468 [3.5 Regression] interpret.cc should
register ffi closure stubs).

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: interp.patch
Type: text/x-patch
Size: 16791 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040516/9f002375/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Invoke.java
Type: text/x-java
Size: 476 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040516/9f002375/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040516/9f002375/attachment.sig>


More information about the Java-patches mailing list