Patch: tcp sockets: removing code duplication

Andrew Haley aph@redhat.com
Wed Apr 21 13:46:00 GMT 2004


Michael Koch writes:
 > Am Montag, 19. April 2004 17:22 schrieb Andrew Haley:
 > >  > -
 > >  > -  return b & 0xFF;
 > >  >  }
 > >
 > > We should not remove this "& 0xFF".
 > >
 > > This patch renders DataInputStream totally broken, because negative
 > > values signal EOF.
 > 
 > 
 > Does the attached patch fixes this for you ? Okay for trunk ?
 > 
 > 2004-04-21  Michael Koch  <konqueror@gmx.de>
 > 
 > 	* gnu/java/net/natPlainSocketImplPosix.cc
 > 	(SocketInputStream::read): Make sure returned data is a byte value.

OK.

Andrew.



More information about the Java-patches mailing list