JFrame DefaultCloseOperation CLOSE_ON_EXIT fixlet

Mark Wielaard mark@klomp.org
Thu Apr 15 13:19:00 GMT 2004


Hi,

On Thu, 2004-04-15 at 11:30, Mark Wielaard wrote:
> Noticed that JFrame get/setDefaultCloseOperation weren't public and
> didn't do the right default thing. So I fixed them and added the correct
> argument checking to setDefaultCloseOperation.

Here is a similar patch for JDialog. But I also had to make the
constructors public to even use this class. There is clearly still much
to do. I stopped playing with it as soon as I saw my first JDialog pop
up. Both JFrame and JDialog should get their constants through the
WindowConstants interface which they now both implement.

2004-04-15  Mark Wielaard  <mark@klomp.org>
                                                                                
        * javax/awt/JFrame.java: Implement WindowConstants. Remove final
        static fields defined in interface.
        * javax/awt/JDialog.java: Likewise.
        (JDialog): Make constructors public.
        (getDefaultCloseOperation): Make public.
        (processWindowEvent): Call System.exit(0) when HIDE_ON_CLOSE set.
        (setDefaultCloseOperation): Make public. Check argument. Add API doc.

> Committed to classpath CVS.
> Could someone with a recent gcj-gui-branch checkout add it there?

Same again.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: JDialog.patch
Type: text/x-patch
Size: 4900 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040415/94f38955/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040415/94f38955/attachment.sig>


More information about the Java-patches mailing list