gtk-peer compile fixes for gcc-2.95

[Mark Wielaard]

Hi,

On Mon, 2004-04-05 at 19:43, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
> 
> Mark> The attached patch does that and enables -Wall for GNU Classpath.
> 
> Nice.  I skimmed it and it generally looks fine to me.
> 
> Mark> It fixes all issues found when compiling with -std=c89. Lots in the gtk
> Mark> peers I am afraid. So please yell and scream if this is to intrusive. It
> Mark> would be good if the gtk-peer stuff in libgcj was also compiled with
> Mark> this flag.
> 
> I think it is a requirement, not just nice to have.  Otherwise we're
> going to end up reintroducing code that isn't C89.
> 
> Here's an untested patch for the GUI branch.
> 
> from  Tom Tromey  <tromey@redhat.com>
> 
> 	* Makefile.am (WARNINGS): Added -std=c89.

Thanks for that.

Here is the gtk+ peer part of my patch.
I'll commit this to classpath now.
Could someone commit it to libgcj mainline and/or gui?
(I only have a 3.4 branch checkout on my development machine at the
moment.)

I want to test the other part of my patch first more carefully before
committing to classpath and enabling -std=c89

2004-04-07  Mark Wielaard  <mark@klomp.org>
                                                                                
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkCheckboxPeer.c:
        Changed C++ comments into C comments. Removed commented out code.
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:
        Likewise.
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c:
        Likewise.
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkFileDialogPeer.c:
        Likewise.
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c:
        Likewise.
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextComponentPeer.c:
        Likewise.
        * native/jni/gtk-peer/gthread-jni.c:
        Likewise.

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk-peer-cleanup.patch
Type: text/x-patch
Size: 13590 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040407/40e6e6d7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20040407/40e6e6d7/attachment.sig>