[PATCH] Fix to KEY events
Thomas Fitzsimmons
fitzsim@redhat.com
Wed Dec 3 20:29:00 GMT 2003
On Wed, 2003-12-03 at 14:54, Tom Tromey wrote:
> >>>>> "Fernando" == Fernando Nasser <fnasser@redhat.com> writes:
>
> Fernando> Most credits should go to Tom Fitzsimmons, but here is a fix
> Fernando> for an annoying problem that would make any keypress (even a
> Fernando> SHIFT key one) cause a checkbox to toggle, buttons to appear
> Fernando> to have been pressed etc.
>
> Fernando> + /* XXX We don't know what the intention was here, but
> Fernando> + this is definitively _not_ the right thing to do
> Fernando> gtk_widget_activate (window->focus_widget);
> Fernando> + */
>
> Normally we just delete unused code. Is it likely this code will be
> resurrected in the near future? If not, let's just remove it.
>
> Anyway, this is ok.
>
> Hmm, I was going to say that we usually write "FIXME" instead of
> "XXX", but grep shows that both seem to be pretty common. Learn
> something every day :-)
>
Maybe we should use "XXX" for "I'm not sure about this:" and "FIXME" for
"This is a problem but we can fix it later:".
Tom
More information about the Java-patches
mailing list