[PATCH] [MinGW]: Don't add dll[im/ex]port attributes to libgcj, unless dll build
Tom Tromey
tromey@redhat.com
Mon Nov 10 17:24:00 GMT 2003
>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:
Mohan> - Once Danny does this, can someone approve this?
This is ok. I have one comment, and one minor change I'd like you to
make before committing.
Mohan> (__GCJ_DLL__): New macro, controlling __GCJ_JNIIMPEXP__.
I assume the plan is to define this macro when we are able to build
libgcj as a DLL on Windows?
Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_GetDefaultJavaVMInitArgs (void *);
Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_CreateJavaVM (JavaVM **, void **, void *);
Mohan> +extern __GCJ_JNIIMPEXP__ jint JNICALL JNI_GetCreatedJavaVMs(JavaVM **, jsize, jsize *);
Please wrap these lines at 80 columns, per the GNU coding standards.
Tom
More information about the Java-patches
mailing list