Patch: Label fixes
Tom Tromey
tromey@redhat.com
Fri Nov 7 19:23:00 GMT 2003
>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:
Tom> This patch reverts the change made here:
Tom> 2003-07-24 Thomas Fitzsimmons <fitzsim@redhat.com>
Tom> * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkLabelPeer.c (create):
Tom> Don't pack label in an event box.
Tom> and implements new methods that "unwrap" the label from the event box.
This looks good, thanks. Just one comment...
Tom> +JNIEXPORT void JNICALL
Tom> +Java_gnu_java_awt_peer_gtk_GtkLabelPeer_setText
Tom> + (JNIEnv *env, jobject obj, jstring text)
Tom> +{
Tom> ...
Tom> + str = (*env)->GetStringUTFChars (env, text, 0);
You never release the characters in this function.
Tom
More information about the Java-patches
mailing list