[PATCH] PR/12647: MinGW: Respect refcount in _Jv_CondWait

Tom Tromey tromey@redhat.com
Fri Oct 24 18:16:00 GMT 2003


>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:

Mohan> I could go either way on this. pthread_mutex_init creates a
Mohan> fast mutex on Linux by default, whereas Win32
Mohan> InitializeCriticalSection() always creates a recursive
Mohan> mutex. Part of me likes the simplicity of your solution, but
Mohan> part of me says that by leaving the Windows code the way it is,
Mohan> we could potentially more easily catch future errors in the
Mohan> library which don't have matching _Jv_MutexLock /
Mohan> _Jv_MutexUnlock calls.

Either way is ok by me.  I think your patch as-is is fine.

Tom



More information about the Java-patches mailing list