FYI: Patch: java.text.SimpleDateFormat merge from classpath

Bryce McKinlay bryce@mckinlay.net.nz
Fri Sep 26 03:56:00 GMT 2003


On Friday, Sep 26, 2003, at 05:27 Pacific/Auckland, Michael Koch wrote:

> I commited the attached patch to trunk to merge
> java.text.SimpleDateFormat with classpath again.

> +2003-09-25  Guilhem Lavaux  <guilhem@kaffe.org>
> +
> +	* java/text/SimpleDateFormat.java (parse): Don't use class calendar
> +	field.

This patch doesn't look right. We don't want to be cloning the calendar 
object on every parse() call - its a big performance penalty. If 
calendar.clear() is not correctly reseting the calendar instance, then 
the bug is in Calendar, not SimpleDateFormat.

Guilhem, could you explain the motivation behind this change?

Regards

Bryce




More information about the Java-patches mailing list