[Patch] natString.cc: Some fixes for bounds checking arithmetic.

Tom Tromey tromey@redhat.com
Tue Sep 23 18:12:00 GMT 2003


>>>>> "Ralph" == Ralph Loader <suckfish@ihug.co.nz> writes:

Ralph> libgcj contains many places where checking of array index arguments
Ralph> passed to methods is done incorrectly.

Nice work.

Ralph> One of the test cases in the patch is commented out - it causes a
Ralph> warning during the link, which seems to cause the test to fail
Ralph> extraneously.  If someone can tell me how to turn off or ignore the
Ralph> warning message, I will do so and uncomment the test case.

Do you get a warning because String.getBytes is deprecated?
There's no way to change the options for just one file.  But we
should probably run the test suite with -Wno-deprecated anyway --
that should be easy to change in lang.exp.

I wonder if these tests should go in Mauve instead.  Then they'll be
shared with other free VMs.

Tom



More information about the Java-patches mailing list