[patch] merge character encoding aliases into System from Classpath

Bryce McKinlay bryce@mckinlay.net.nz
Sun Sep 21 21:50:00 GMT 2003


On Monday, Sep 22, 2003, at 08:05 Pacific/Auckland, Mark Wielaard wrote:

> On Sun, 2003-09-21 at 20:17, Nathanael Nerode wrote:
>> This is a partial merge from classpath.  (I'm working on synchronizing
>> the classes which now have 'VM' counterparts, bit by bit.)  OK?
>>
>> 2001-01-08  Mark Wielaard  <mark@klomp.org>
>>
>> 	* java/lang/System.java (insertGNUProperties): Add standard character
>> 	encoding aliases.
>> 	(Merged from Classpath 2003-09-21)
>
> I think it is better to keep the difference here since these properties
> are used by gnu.java.io.EncodingManager which is only in GNU Classpath.
> Merging gnu.java.io from classpath and gnu.gcj.convert would be nice
> though. Then we could also move to the new java.nio.charset.spi
> structure.

Thanks Mark, I agree. These definitions should really be in a 
properties file somewhere, or at least in the character conversion code 
itself. I don't think they belong in System.java. We want to avoid 
adding a lot of superfluous strings and calls to the initialization 
code if possible because minimizing startup time is important for 
libgcj. These probably don't have a significant impact by themselves, 
but these things eventually add up.

I'd love to see some efficient java.nio.charset based converters.

Regards

Bryce.




More information about the Java-patches mailing list