[libava/win32]: Don't add dll[im/ex]port attributes to libgcj, unless dll build

Tom Tromey tromey@redhat.com
Thu Aug 7 00:24:00 GMT 2003


>>>>> "Danny" == Danny Smith <danny_r_smith_2001@yahoo.co.nz> writes:

Danny> The following patch is ugly, but fixes the problem with static
Danny> libgcj.a on windows, while allowing the declaration of
Danny> dllimport/export attributes if building libgcj.as dll.

I'd like one of the Windows folks to comment on this.

My own comments are below.  This is basically fine by me.

Danny> 	2003-08-06  Danny Smith  <dannysmith@users.sourceforge.net>
Danny> 	* jni.cc (JNI_CreateJavaVM): Remove JNIEXPORT.
Danny> 	(JNI_GetCreatedJavaVMs): Likewise.
Danny> 	(JNI_GetDefaultJavaVMInitArgs): Likewise.
Danny> 	* include/jni.h (JNIIMPEXP): Remove definition
Danny> 	and replace with...
Danny> 	(__GCJ_JNIIMPEXP): New macro, applicable only to libgcj
Danny> 	symbols,
Danny> 	(__GCJ_DLL): New macro, controlling __GCJ_JNIIMPEXP.

We're already using names like __FOO__.  So could you add a trailing
"__" to these two new defines?

Tom



More information about the Java-patches mailing list