Patch: natSocketChannelImpl.cc use elements + explicit cast
Michael Koch
konqueror@gmx.de
Mon Mar 10 15:27:00 GMT 2003
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Samstag, 8. März 2003 06:19 schrieb Mohan Embar:
> This patch addresses something that broke under the MingW build,
> possibly because jbyte seems to be unsigned char and not signed
> char on Win32. It also appeared to me that "elements(data)" was
> needed instead of just plain "data". Am I right?
>
> Also see my comment about the cast to char* instead of const char*
> in ::send().
> 2003-03-07 Mohan Embar <gnustuff@thisiscool.com>
>
> * gnu/java/nio/natSocketChannelImpl.cc (SocketRead): use
> elements(data) and explicitly cast to char* on platforms
> where jbyte is not signed char
> (SocketWrite): idem
Looks okay. Should I commit it ?
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+bK78WSOgCCdjSDsRAi7+AKCMKok0/CB2mD4lRutckLSdXfbWSQCfRD/9
NUAhe5hzJ7G1U3QyReLucvA=
=k4aI
-----END PGP SIGNATURE-----
More information about the Java-patches
mailing list