Patch: Suppress MingW Build-Busting Net Code

Michael Koch konqueror@gmx.de
Mon Mar 10 15:23:00 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Samstag, 8. März 2003 05:13 schrieb Mohan Embar:
> Hi Patch Folks,
>
> Taking the tact that something is better than nothing, this patch
> #ifdefs out net code which currently breaks the MingW build. The
> same problem of BSD/Windows Sockets incompatibilities in java.net
> is rearing its head in the java.nio.channels package. Given that
> the consensus seemed to be to split out the code in java.net,
> shouldn't the same approach be followed in gnu.java.nio?
>
> I know the #ifdefs are ugly, but they currently run rampant in
> java.net and they unbreak the MingW build while waiting for the
> glorious day that we properly split out the code. Your call....
>
> Enjoy.
>
> -- Mohan
> http://www.thisiscool.com/
> http://www.animalsong.org/
>
> ChangeLog
> 2003-03-07  Mohan Embar  <gnustuff@thisiscool.com>
>
> 	* gnu/java/nio/natSelectorImpl.cc (java_do_select): #ifdef
> 	out functionality not implemented under mingw (_Jv_select())

The correct solution would be to add a dummy _Jv_select to 
libjava/win32.cc.

> 	* java/net/natPlainDatagramSocketImpl.cc (peek): #ifdef
> 	out code that breaks mingw build (ECONNREFUSED)
> 	(peekData): idem
> 	(send): idem
> 	(receive): idem

Are you sure this is the wrong exception ? What does mingw return when 
connection is refused or not possible ?


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+bK4dWSOgCCdjSDsRAsxUAJ9SUs3T1u/DLLper3hskMGvBNXfcwCdG6ug
UJwCw423NIR/JZnXcCD9pFI=
=C6YF
-----END PGP SIGNATURE-----



More information about the Java-patches mailing list