Patch: jcf-path.c and filename case-insensitivity on Win32
Andrew Haley
aph@redhat.com
Sun Mar 2 16:38:00 GMT 2003
Mohan Embar writes:
> Hi People,
>
> >See Tom's comment -- declare COMPARE_FILENAMES appropriately. We
> >don't want HAVE_DOS_BASED_FILE_SYSTEM all over the place if we can
> >possibly avoid it.
> >
> >Otherwise this is fine.
>
> I'm going to stick my neck out here: would it be ethically/morally
> objectionable to have platform-dependent files where we call into
> platform-dependent same-named functions for things like these?
In principle, but if we ever get into that much platform-dependent
complexity in the compiler front end we are going it totally the wrong
direction.
> And if you're worried about performance on UNIX in the case of
> something like strcmp,
In the front end? No way. It must be right.
> do a #define where things would resolve to the real deal on UNIX,
> but a function call into the platform- dependent file on Win32?
>
> I'm asking this because there are a few strategic opens / fopens
> in jcf-*.c which, if you checked for the existence of the file
> of the exact case on Win32, you would get the compiler working
> on MingW.
This should be possible to parameterize with a macro in the same way.
Go for it.
Andrew.
More information about the Java-patches
mailing list