Patch for Preview: Win32 Process Implementation
Tom Tromey
tromey@redhat.com
Sat Mar 1 23:01:00 GMT 2003
>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:
Mohan> 2003-02-23 Mohan Embar <gnustuff@thisiscool.com>
This looks good to me. I'm checking it in to the trunk and the 3.3
branch.
It is small enough, imho, not to need paperwork. However, future
patches will.
A couple trivial nits to pick:
Mohan> * java/lang/natWin32Process.cc (java::lang::ConcreteProcess::startProcess):
Mohan> double-quote each program array element passed to CreateProcess
In the ChangeLog entry, just put the function name in the parens.
Usually, in libgcj, there's no need to spell out the full class name.
Mohan> + if (i>0)
You need spaces around the `>'.
Tom
More information about the Java-patches
mailing list