Patch: FYI: gcj ICE fixlet

Tom Tromey tromey@redhat.com
Sat Mar 1 21:45:00 GMT 2003


I'm checking this in as obvious on the trunk.

My earlier deprecation fix introduced an ICE.  If the user's code has
a bug, in one situation we can have `decl == NULL_TREE'; this causes
the deprecation check to crash.  Other code in this same function
checks decl as well, hence this patch.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* parse.y (jdep_resolve_class): Only check deprecation if we found
	a decl.

Index: parse.y
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/parse.y,v
retrieving revision 1.423
diff -u -r1.423 parse.y
--- parse.y 28 Feb 2003 20:53:47 -0000 1.423
+++ parse.y 1 Mar 2003 21:36:52 -0000
@@ -5464,7 +5464,7 @@
       JDEP_RESOLVED (dep, decl);
       /* If there is no WFL, that's ok.  We generate this warning
 	 elsewhere.  */
-      if (JDEP_WFL (dep) != NULL_TREE)
+      if (decl && JDEP_WFL (dep) != NULL_TREE)
 	check_deprecation (JDEP_WFL (dep), decl);
     }
 



More information about the Java-patches mailing list