Possible awt patches

[Boehm, Hans]

For the record, I attached the patch I checked into the gcc trunk.  I don't have a Classpath tree, so I would appreciate it if Tom could check it on there.

I changed a few things from the last version I sent out:

- A minor fix to the ChangeLog.

- A fix for setFont on buttons, so that it actually works.

- I removed the parentheses from the return statements.  (This makes the patch less consistent with what was there before, but presumably that's temporary?)

- I changed getPreferredSize for peer-less text areas to return Dimension(0,0) which seems to be what Sun's JDK does.

It looks like I'm still having trouble getting some events from at least TextAreas and Checkboxes.  But otherwise things are starting to look OK.


Hans

> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Sunday, February 16, 2003 2:41 PM
> To: Boehm, Hans
> Cc: 'java-patches@gcc.gnu.org'
> Subject: Re: Possible awt patches
> 
> 
> >>>>> "Hans" == Boehm, Hans <hans_boehm@hp.com> writes:
> 
> Hans> Here is a bigger version of the patch.  It fixes enough bugs to
> Hans> almost make CRCalc usable.  (CRCalc works if you use purely the
> Hans> mouse and not the keyboard.)  I have a bit more confidence in
> Hans> this version as a result.
> 
> This looks good to me.
> 
> Hans> I'm still not positive about the guesses for getPreferredSize.
> Hans> If I take those out, I get NullPointerExceptions on the result,
> Hans> but those seem to be caught somewhere.  I'd be inclined to put
> Hans> in the guess, simply because it makes debugging easier.
> 
> Yeah.  Did you try to find out what the JDK does in this situation?
> 
> Hans> The setFont part of the patch is also a bit dubious.  I don't
> Hans> think it's quite doing the right thing.
> Hans> [ ... ]
> Hans> Hence I would like to check it in, at least in the absence of a
> Hans> better patch by a GTK expert.
> 
> Sounds good.
> 
> Hans> OK for trunk?  What about 3.3?
> 
> I've only been putting AWT fixes on the trunk since the peers aren't
> in 3.3.
> 
> There are a couple places in the patch where `return (...)' should be
> written without the parens.  Please fix those.
> 
> Finally, can you check this in to Classpath as well?  If not, send me
> the updated patch and I will do it.  The AWT code is kept in pretty
> close synchronization (which reminds me; some AWT changes went into
> Classpath recently; I'll bring them over in the near future.)
> 
> Tom
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0218awtdiffs
Type: application/octet-stream
Size: 18002 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/java-patches/attachments/20030219/1cda127c/attachment.obj>