[PATCH] java.awt

Tom Tromey tromey@redhat.com
Wed Feb 12 20:07:00 GMT 2003


>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> This patch fixes some glitches in java.awt. Please review and
Michael> comment.

Thanks for doing this.

Note that java.awt is (with the exception of a minor change in
Toolkit) fully merged with Classpath.  (Well, there are a couple
Classpath changes I haven't yet brought over...)  Changes have to go
in to Classpath as the same time.

I didn't look to make sure that the spec changes you made are correct.
I'm sure they are though.

Michael> +++ /home/mkoch/src/gcc-work/libjava/java/awt/Polygon.java	2003-02-12 08:33:09.000000000 +0100
Michael> @@ -120,6 +120,7 @@
Michael>      // Leave room for growth.
Michael>      xpoints = new int[4];
Michael>      ypoints = new int[4];
Michael> +    npoints = 4;
Michael>    }

I think this patch is incorrect.  `npoints' is the number of points in
the polygon, but this constructor makes an empty polygon.  The "[4]"s
because we assume the user will add a point or two, and we don't want
to immediately grow it.

The rest of this is fine.  Please commit.

Tom



More information about the Java-patches mailing list