take #2. was: BigInteger patch (long)

Per Bothner per@bothner.com
Sat Feb 1 04:24:00 GMT 2003


Raif S. Naffah wrote:
> here is a modified Changelog diff as per above style:

Close enough.  A few more nits, but Tom can take care of them,
if he agrees:

	* java/math/BigInteger.java (make(long)): Merged into valueOf(long).
+
+	* java/math/BigInteger.java (make(int[],int), add(int,int),
+	add(BI,BI,int), times(BI,int), divide(long,long,BI,BI,int), gcd(BI),
+	isProbablePrime(int), shift(BI,int), valueOf(String,int), neg(BI),
+	bitOp(int,BI,BI), and(BI,int)): Use valueOf(long) instead of make(long).

I'd consider this one logical change, so it should be one paragraph.

+	* java/math/BigInteger.java (isOdd, isMinusOne, pow): Removed.  not used.

Incorrect capitalization.  I'd write "Removed - not used."

+	(toString(int)): idem.

Isn't "item" the usual spelling?  In any case, we prefer the English
"Likewise."

+	* java/math/BigInteger.java (gcd(int,int)): Declared 'tmp' once as local
+	var and used where needed.

Personally, as I mentioned, I disagree with this change.

+	* java/math/BigInteger.java (format(int,StringBuffer)): Removed
+	invoacation of MPN.chars_per_word().  not used.

s/invoacation/invocation/

 >>I assume you have an assignment with the FSF?
 > i have a now-and-future assignment for GNU Crypto and GNU Classpath.

I assume that's ok.  Certainly if Classpath uses the same
implementation.  Tom?
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/per/



More information about the Java-patches mailing list