BigInteger patch (long)

Per Bothner per@bothner.com
Sat Feb 1 02:51:00 GMT 2003


The ChangeLog is a little too everything-and-the-
kitchen-sink-too.  Changes that are more-or-less
separate should be listed separately.  For example:

	* java/math/BigInteger.java (isOdd, isMinusOne, ...)
	Removed usused methods.

	* java/math/BigInteger.java:  Reduce the number of
	temporaries created by euclidInv.
	(euclidInv(int,int,int): Now returns ...

	* java/math/BigInteger.java:  Various style changes:
	pow(int): Removed 'else' keyword.
	...

	* java/math/BigInteger.java (make):  Remove private field.
	Instead "inline" it into valueOf.
	(bitOp(int,BI,BI)): Use valueOf(long) instead of make(long).

Note the parens before the method names when before the colon.

Note the blank lines between logically separate changes.

Note also we don't normally add the extra 2 spaces of indentation.

Note since you're editing libjava/ChangeLog there
is no need to least libjava/java ...

I assume you have an assignment with the FSF?
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/per/



More information about the Java-patches mailing list